Fix strict warning and small cleanups

This commit is contained in:
Niklas Laxström 2010-09-11 14:31:16 +00:00
parent 2fc7ce97dc
commit 2aacf652ee

View file

@ -12,8 +12,7 @@
* @ingroup Extensions * @ingroup Extensions
* @author Tim Laqua <t.laqua@gmail.com> * @author Tim Laqua <t.laqua@gmail.com>
*/ */
class ContributionScores extends IncludableSpecialPage class ContributionScores extends IncludableSpecialPage {
{
public function __construct() { public function __construct() {
parent::__construct( 'ContributionScores' ); parent::__construct( 'ContributionScores' );
} }
@ -101,7 +100,7 @@ class ContributionScores extends IncludableSpecialPage
"<td>" . wfMsgHtml( 'contributionscores-changes' ) . "</td>\n" . "<td>" . wfMsgHtml( 'contributionscores-changes' ) . "</td>\n" .
"<td>" . wfMsgHtml( 'contributionscores-username' ) . "</td>\n"; "<td>" . wfMsgHtml( 'contributionscores-username' ) . "</td>\n";
$skin =& $wgUser->getSkin(); $skin = $wgUser->getSkin();
$altrow = ''; $altrow = '';
while ( $row = $dbr->fetchObject( $res ) ) { while ( $row = $dbr->fetchObject( $res ) ) {
$output .= "</tr><tr class='{$altrow}'>\n<td class='content'>" . $output .= "</tr><tr class='{$altrow}'>\n<td class='content'>" .
@ -140,8 +139,6 @@ class ContributionScores extends IncludableSpecialPage
function execute( $par ) { function execute( $par ) {
global $wgRequest, $wgOut, $wgHooks; global $wgRequest, $wgOut, $wgHooks;
wfLoadExtensionMessages( 'ContributionScores' );
$this->setHeaders(); $this->setHeaders();
if( $this->including() ) { if( $this->including() ) {
@ -201,7 +198,7 @@ class ContributionScores extends IncludableSpecialPage
array(0,50)); array(0,50));
} }
$wgOut->addWikiText( wfMsg( 'contributionscores-info' ) ); $wgOut->addWikiMsg( 'contributionscores-info' );
foreach ( $wgContribScoreReports as $scoreReport) { foreach ( $wgContribScoreReports as $scoreReport) {
if ( $scoreReport[0] > 0 ) { if ( $scoreReport[0] > 0 ) {