pianello/pianello-web-app
pianello/pianello-web-app
2
0
Fork 0
Code Issues 3 Pull requests Projects 1 Releases Packages 1 Wiki Activity

Let Dockerfile to the build #4

Merged
zbolo-wd merged 11 commits from move-docker-compose into main 2023-06-27 15:59:45 +02:00
Conversation 1 Commits 11 Files changed 6 +32 -10
ale commented 2023-05-31 21:09:19 +02:00
Owner
Copy link

I propose that we to let the Dockerfile do the build.

Why:

  • We can enojy the pipeline build cache if future builds share yarn.lock.
  • We use a smaller container for running the pipeline, node:20.2.0-alpine3.16 was used but it's better if we use an already pulled pipeline image.
I propose that we to let the `Dockerfile` do the build. Why: - We can enojy the pipeline build cache if future builds share `yarn.lock`. - We use a smaller container for running the pipeline, `node:20.2.0-alpine3.16` was used but it's better if we use an already pulled pipeline image.
ale added 10 commits 2023-05-31 21:09:20 +02:00 
I think this is way we should building the project inside a subfolder
ale requested review from zbolo-wd 2023-05-31 21:09:44 +02:00
zbolo-wd commented 2023-06-01 11:17:59 +02:00
Owner
Copy link

Is it still a WIP?

Is it still a WIP?
zbolo-wd changed title from WIP: Let Dockerfile to the build to Let Dockerfile to the build 2023-06-27 15:51:44 +02:00
zbolo-wd added 1 commit 2023-06-27 15:51:49 +02:00
Merge branch 'main' into move-docker-compose
Some checks failed
ci/woodpecker/pr/build Pipeline failed
Details
6af005c1a0
zbolo-wd merged commit 5280d47c1d into main 2023-06-27 15:59:45 +02:00
zbolo-wd deleted branch move-docker-compose 2023-06-27 15:59:45 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
zbolo-wd
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: pianello/pianello-web-app#4
No description provided.
Delete branch "move-docker-compose"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?